pkg/tinydtls: various bugfixes #21827
Open
+41
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, sock_dtls_get_event_session would return a previous session instead of none as documented fixes an assertion failure in tests/pkg/tinydtls_sock_async on a second request
crasbe
added
Type: bug
crasbe
reviewed
Oct 29, 2025
miri64
previously requested changes
Oct 29, 2025
There was a problem hiding this comment.
Mostly just some nits on documentation and commit messages.
Also, could you maybe in the testing instructions explicitly provide some of the things you did to "play around with the tests" (beyond the reproducing instructions in the summary), so I can test it myself. Thanks!
This way unconsumed application data is not overwritten.
also document that other messages are currently silently ignored from the mbox
They are not needed as the sock_async_event (and potential other backends should) accumulate(s) the flags internally already, and they have been sent out on data arrival or connection establishment already.
mguetschow
force-pushed
the
dtls-fixes
branch
from
5ea1ee3 to
59446cf
Compare
mguetschow
commented
Oct 30, 2025
|
Currently no time for testing, so I leave that and the final ACK resulting from that to someone else :-) |
benpicco
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing #21582, we found various issues in the current tinydtls
sock_dtlsimplementation.On master,
tests/pkg/tinydtls_sock_asyncwould throw an assertion failure on the second request from another instance of the same application (since the async session information is not reset). With the first commit, this does not happen anymore.On master,
examples/networking/coap/gcoap_dtlswould print (withDEBUGenabled)and not respond to any packages sent out by libcoap (with
coap-client-gnutls "coaps://[<IP>%tap0]/.well-known/core" -k "secretPSK" -u "Client_identity"(presumably because the application data message is returned instead of the handshake completion signal). With the third commit of this PR, it works as expected.The zero-copy
sock_dtls_recv_bufAPIs are currently untested by application code (gcoap uses copy-versions), but unicoap does use them. Applying #21582 (with some changes) on top of this PR shows that the fifth commit is needed for proper functioning.The sixth commit removes unnecessary (and broken) logic which would send flags more than once. Those are not needed as the
sock_async_event(and potential other backends should) accumulate(s) the flags internally already.Testing procedure
Play around with
tests/pkg/tinydtls_sock_asyncandexamples/networking/coap/gcoap_dtls, or any other (your favorite) application using dtls_sock over tinydtls.References
Some of the changes have already been discussed with @miri64 offline.